Require Cython 3 as a dependency #447
Conversation
setup.py
Outdated
| @@ -115,14 +117,15 @@ | |||
| long_description=long_description, | |||
| long_description_content_type="text/markdown", | |||
| install_requires=[ | |||
| "cython~=3.0", | |||
There was a problem hiding this comment.
Cython is not a runtime dependency, so doesn't need to be in install_requires. It's only needed for building.
There was a problem hiding this comment.
Should I then remove it from requirements.txt too? Or is it useful to have it there when someone wants to install both build and runtime dependencies using pip install -r requirements.txt?
There was a problem hiding this comment.
requirements.txt is for developers to set up a useful working environment, so the Cython dependency should remain in there. The install_requires section in setup.py should only specify the packages required to use an already-built wheel after it has been installed (it's not a great keyword name IMO).
There was a problem hiding this comment.
Thanks for the explanation. It's done.
There was a problem hiding this comment.
I'm out of my depth here. I would ask @jacklovell and @vsnever to agree on this one.
This PR fixes #446.
-Wno-unreachable-code-fallthroughcompilation flag is added to silence false unreachable code warnings.