Replace the half-sum with numerical integration when calculating the bremsstrahlung spectrum #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to have test coverage of this too. |
…rms of physical constants as suggested by @skuba31.
Done. I also added a fix for #409 so as not to rewrite the test in a separate PR. |
… in response to @skuba31 comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #395 by adding
integratorargument to theBremsstrahlungemission model. The newBremsFunction(Function1D)class is added for compatibility withIntegrator1D.Update. This also fixes #409 by replacing the numerical constant with an exact expression and changing the reference to bremsstrahlung equation in the docstring.