-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zeeman splitting and Doppler broadening to StarkBroadenedLine and move line shapes models to a dedicated submodule #400
Conversation
…cts to StarkBroadenedLine.
…s as in B.A. Lomanowski 2015 NF paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Test coverage, documentation and demo provision is good for the new additions. Since the beam line shape classes have also been moved, could you add some tests for both BeamLineShapeModel
and BeamEmissionMultiplet
which pass both before and after the refactoring too, just to guarantee no backwards incompatibility?
…let to the default atomic data repository.
Thanks for the review. I added a test for |
This PR fixes #393 and #396.
StarkBroadenedLine
now takes into account Zeeman splitting and Doppler broadening and usesZeemanLineShapeModel
as a base class.Additional changes:
add_lorentzian_line()
is added by analogy toadd_gaussian_line()
show_supported_transitions()
ofStarkBroadenedLine
andParametrisedZeemanTriplet
has been made a class method, because the user cannot initialise instants without knowing what transitions are supported by these classes.stark_broadening.py
now plots in logscale to show the Lorentzian nature of the spectral line wings.stark_zeeman.py
is added to show the Zeeman splitting of the Stark-broadened line. The plasma parameters are set the same as in Figure 2 in B. Lomanowski et al.test_lineshapes.py
is updated to reflect the changes inStarkBroadenedLine
.