Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parent Branch] Next js Pages Router to App Router migration #1146

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

eleanorreem
Copy link
Contributor

Resolves #enter-issue-number

What changes did you make and why did you make them?

Did you run tests? Share screenshot of results:

How did you find us? (GitHub, Google search, social media, etc.):

boodland and others added 10 commits September 11, 2024 16:00
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Add google tag manager to root layout

* Change strategy as worker is experimental and is not including the script

* Move gtm to body as next is including it in head properly

* Add comment to tackle in the future

* Move gtm script from _document to _app
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Use script tag and set id

* Add rollbar script to root layout

* Make it beforeInteractive so it is included in the head

* Move to _app as next/script is not working in _document
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Move primary color to a constant so can be used in a server component (root layout)

* Create rootMetadata

* Fix format

* Add metadata to root layout

---------

Co-authored-by: eleanorreem <[email protected]>
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Make error boundary client component

* Add ErrorBoundary component to root layout

* Create app router error route test page

---------

Co-authored-by: eleanorreem <[email protected]>
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Create theme registry component

* Add ThemeRegistry to root layout

* Make theme client component

* Install mui for app router

---------

Co-authored-by: eleanorreem <[email protected]>
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ❌ Failed (Inspect) Sep 20, 2024 2:17pm

@eleanorreem eleanorreem changed the title Next js Pages Router to App Router migration [Parent Branch] Next js Pages Router to App Router migration Sep 20, 2024
* Add basic Root Layout

* Add metadata

* Add reference included by next

* Add comment to explain the default meta tags

* Add public testing page to check the migration

* Remove non required file

* Create Analytics component

* Add analytics to root layout

* Update layout.tsx

---------

Co-authored-by: eleanorreem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants