Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware::Rack: don't rely on Prosopite.scan's block execution #75

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Middleware::Rack: don't rely on Prosopite.scan's block execution #75

merged 1 commit into from
Dec 14, 2023

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented Nov 13, 2023 •
edited
Loading

  • Change the rack middleware to no longer use the Prosopite.scan's block execution syntax. This bring it inline with the sidekiq middleware.

@dhruvCW
Rack::Middleware: don't use block scan syntax.
4c4e99c 
Let's not rely on the block argument since
it can have negative side effects.
@dhruvCW dhruvCW changed the title Fix early block execution for Prosopite.scan and the rack middleware. Middleware::Rack: don't rely on Prosopite.scan's block execution Nov 13, 2023
@charkost
Copy link
Owner

fixes any issues caused by the block execution process

Could you elaborate?

@dhruvCW
Copy link
Contributor Author

dhruvCW commented Nov 13, 2023 •
edited
Loading

fixes any issues caused by the block execution process

Could you elaborate?

we noticed that the Prosopite.pause call doesn't seem to pause the scanning. This PR just minimizes the variables for us as we debug why pause doesn't seem to work. I edited the description since it's not actually fixing anything.

@charkost charkost merged commit dda6885 into charkost:main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvCW @charkost