[Rewards] Fixed collectRewardsTx cross-chain request/response handling #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evlekht
changed the title
evlekht
force-pushed
the
dev-c0/reward-import-handlers-fix
branch
3 times, most recently
from
09b88ee
to
3bd7986
Compare
|
in the original PR there is another change in file accounts/abi/bind/bind_test.go |
Its not there, because cortina 0 evm is based on pre-cortina caminogo (but app is still compiled with correct caminogo, since caminogo is starting point for compilation), so we simply didn't update it - there is no need. We'll update dependencies in last commits for clarity. |
mo-c4t
previously approved these changes
Aug 7, 2024
evlekht
force-pushed
the
dev-c0/reward-import-handlers-fix
branch
from
3bd7986
to
966264c
Compare
mo-c4t
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Before this PR, cross-chain request were sent without handling response, which resulted in error messages, cause of unexpected timeout failure response, since pvm weren't sending any response as well.
This PR and chain4travel/caminogo#369 fixes that.
How this works
vm.SendCrossChainRequestmethod which properly utilized handlers and controls response "expectations".How this was tested
Manually.
Additional references
Original PR based on cortina-15 dev
#102