Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Skip camino-wallet-sdk #291

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

aeddaqqa
Copy link

@aeddaqqa aeddaqqa commented Jul 5, 2023

Skip camino-wallet-sdk

Copy link

@rafaelkordonias rafaelkordonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Ayagoumi Ayagoumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeddaqqa aeddaqqa requested a review from Ayagoumi July 14, 2023 10:51
@aeddaqqa aeddaqqa merged commit 9222208 into suite Jul 14, 2023
4 checks passed
@aeddaqqa aeddaqqa deleted the skip-camino-wallet-sdk branch July 14, 2023 12:48
Ayagoumi added a commit that referenced this pull request Aug 28, 2023
* feat: expose the commit hash to the suite (#287)

* kyb modal adjustment (#290)

* kyb modal adjustment

* fix clearing user data before closing disclaimer modal

* [Dependencies] Skip camino-wallet-sdk (#291)

* Skip camino-wallet-sdk

* Fallback to false on non-browser node modules

* Modify webpack fallbacks

---------

Co-authored-by: Rafail Kordonias <[email protected]>

* Adjust settings area styling (#295)

* adjust settings area styling

* fix clearing user data before closing the disclaimer modal

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>

* adjust buildDeposit Tx (#293)

Co-authored-by: Achraf Eddaqqaq <[email protected]>

* Create multisig alias (#292)

* feat: add create multisig alias page
* feat: finalize create msig wallet
* Skip camino-wallet-sdk
* Added a submodule
* update caminojs
* Fallback to false on non-browser node modules
* Modify webpack fallbacks
* fix: update the create multisig wallet component
* removal of unecessery console
* update the create alias components style
* show switch wallet button after the creation of the alias
* save msig addresses and names in localStorage
* Update en.json
* feat: await the saving of the msig in localstorage before form reset

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>

* update multisig on network change (#296)

* Create/Edit multisig alias (#297)

* Edit msig fixes (#298)

* fix: update msig infos on pendingtx change
* fix: break for if the msigAlias is undefined

* fix editing msg with saved keys (#299)

* Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301)

* fix: optional chaining to various code segments
* feat: introduce validation for p-chain addresses
* style: adjust colors for add and remove buttons for improved visibility

* Msig fixes (#303)

* feat: add a custom notification for insufficient funds error

* feat: validate the address and disable buttons when needed

---------

Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>
Co-authored-by: Mohamed Elmoslemany <[email protected]>
Co-authored-by: aeddaqqa <[email protected]>
Ayagoumi pushed a commit that referenced this pull request Sep 14, 2023
* Skip camino-wallet-sdk

* Fallback to false on non-browser node modules

* Modify webpack fallbacks

---------

Co-authored-by: Rafail Kordonias <[email protected]>
Ayagoumi pushed a commit that referenced this pull request Sep 14, 2023
* Skip camino-wallet-sdk

* Fallback to false on non-browser node modules

* Modify webpack fallbacks

---------

Co-authored-by: Rafail Kordonias <[email protected]>
mo-c4t added a commit that referenced this pull request Sep 14, 2023
* feat: expose the commit hash to the suite (#287)

* kyb modal adjustment (#290)

* kyb modal adjustment

* fix clearing user data before closing disclaimer modal

* [Dependencies] Skip camino-wallet-sdk (#291)

* Skip camino-wallet-sdk

* Fallback to false on non-browser node modules

* Modify webpack fallbacks

---------

Co-authored-by: Rafail Kordonias <[email protected]>

* Adjust settings area styling (#295)

* adjust settings area styling

* fix clearing user data before closing the disclaimer modal

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>

* adjust buildDeposit Tx (#293)

Co-authored-by: Achraf Eddaqqaq <[email protected]>

* Create multisig alias (#292)

* feat: add create multisig alias page
* feat: finalize create msig wallet
* Skip camino-wallet-sdk
* Added a submodule
* update caminojs
* Fallback to false on non-browser node modules
* Modify webpack fallbacks
* fix: update the create multisig wallet component
* removal of unecessery console
* update the create alias components style
* show switch wallet button after the creation of the alias
* save msig addresses and names in localStorage
* Update en.json
* feat: await the saving of the msig in localstorage before form reset

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>

* update multisig on network change (#296)

* Create/Edit multisig alias (#297)

* Edit msig fixes (#298)

* fix: update msig infos on pendingtx change
* fix: break for if the msigAlias is undefined

* fix editing msg with saved keys (#299)

* Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301)

* fix: optional chaining to various code segments
* feat: introduce validation for p-chain addresses
* style: adjust colors for add and remove buttons for improved visibility

* Msig fixes (#303)

* feat: add a custom notification for insufficient funds error

* feat: validate the address and disable buttons when needed

---------

Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>
Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Ayoub Agoumi <[email protected]>
mo-c4t added a commit that referenced this pull request Sep 14, 2023
* feat: expose the commit hash to the suite (#287)

* kyb modal adjustment (#290)

* kyb modal adjustment

* fix clearing user data before closing disclaimer modal

* [Dependencies] Skip camino-wallet-sdk (#291)

* Skip camino-wallet-sdk

* Fallback to false on non-browser node modules

* Modify webpack fallbacks

---------

Co-authored-by: Rafail Kordonias <[email protected]>

* Adjust settings area styling (#295)

* adjust settings area styling

* fix clearing user data before closing the disclaimer modal

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>

* adjust buildDeposit Tx (#293)

Co-authored-by: Achraf Eddaqqaq <[email protected]>

* Create multisig alias (#292)

* feat: add create multisig alias page
* feat: finalize create msig wallet
* Skip camino-wallet-sdk
* Added a submodule
* update caminojs
* Fallback to false on non-browser node modules
* Modify webpack fallbacks
* fix: update the create multisig wallet component
* removal of unecessery console
* update the create alias components style
* show switch wallet button after the creation of the alias
* save msig addresses and names in localStorage
* Update en.json
* feat: await the saving of the msig in localstorage before form reset

---------

Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>

* update multisig on network change (#296)

* Create/Edit multisig alias (#297)

* Edit msig fixes (#298)

* fix: update msig infos on pendingtx change
* fix: break for if the msigAlias is undefined

* fix editing msg with saved keys (#299)

* Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301)

* fix: optional chaining to various code segments
* feat: introduce validation for p-chain addresses
* style: adjust colors for add and remove buttons for improved visibility

* Msig fixes (#303)

* feat: add a custom notification for insufficient funds error

* feat: validate the address and disable buttons when needed

---------

Co-authored-by: Achraf Eddaqqaq <[email protected]>
Co-authored-by: Rafail Kordonias <[email protected]>
Co-authored-by: aeddaqqa <[email protected]>
Co-authored-by: Ayoub Agoumi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants