forked from ava-labs/avalanche-wallet
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependencies] Skip camino-wallet-sdk #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeddaqqa
force-pushed
the
skip-camino-wallet-sdk
branch
from
July 12, 2023 11:27
f1c1af8
to
5c72909
Compare
rafaelkordonias
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ayagoumi
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ayagoumi
approved these changes
Jul 14, 2023
Ayagoumi
added a commit
that referenced
this pull request
Aug 28, 2023
* feat: expose the commit hash to the suite (#287) * kyb modal adjustment (#290) * kyb modal adjustment * fix clearing user data before closing disclaimer modal * [Dependencies] Skip camino-wallet-sdk (#291) * Skip camino-wallet-sdk * Fallback to false on non-browser node modules * Modify webpack fallbacks --------- Co-authored-by: Rafail Kordonias <[email protected]> * Adjust settings area styling (#295) * adjust settings area styling * fix clearing user data before closing the disclaimer modal --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> * adjust buildDeposit Tx (#293) Co-authored-by: Achraf Eddaqqaq <[email protected]> * Create multisig alias (#292) * feat: add create multisig alias page * feat: finalize create msig wallet * Skip camino-wallet-sdk * Added a submodule * update caminojs * Fallback to false on non-browser node modules * Modify webpack fallbacks * fix: update the create multisig wallet component * removal of unecessery console * update the create alias components style * show switch wallet button after the creation of the alias * save msig addresses and names in localStorage * Update en.json * feat: await the saving of the msig in localstorage before form reset --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> * update multisig on network change (#296) * Create/Edit multisig alias (#297) * Edit msig fixes (#298) * fix: update msig infos on pendingtx change * fix: break for if the msigAlias is undefined * fix editing msg with saved keys (#299) * Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301) * fix: optional chaining to various code segments * feat: introduce validation for p-chain addresses * style: adjust colors for add and remove buttons for improved visibility * Msig fixes (#303) * feat: add a custom notification for insufficient funds error * feat: validate the address and disable buttons when needed --------- Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> Co-authored-by: Mohamed Elmoslemany <[email protected]> Co-authored-by: aeddaqqa <[email protected]>
Ayagoumi
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Skip camino-wallet-sdk * Fallback to false on non-browser node modules * Modify webpack fallbacks --------- Co-authored-by: Rafail Kordonias <[email protected]>
Ayagoumi
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Skip camino-wallet-sdk * Fallback to false on non-browser node modules * Modify webpack fallbacks --------- Co-authored-by: Rafail Kordonias <[email protected]>
mo-c4t
added a commit
that referenced
this pull request
Sep 14, 2023
* feat: expose the commit hash to the suite (#287) * kyb modal adjustment (#290) * kyb modal adjustment * fix clearing user data before closing disclaimer modal * [Dependencies] Skip camino-wallet-sdk (#291) * Skip camino-wallet-sdk * Fallback to false on non-browser node modules * Modify webpack fallbacks --------- Co-authored-by: Rafail Kordonias <[email protected]> * Adjust settings area styling (#295) * adjust settings area styling * fix clearing user data before closing the disclaimer modal --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> * adjust buildDeposit Tx (#293) Co-authored-by: Achraf Eddaqqaq <[email protected]> * Create multisig alias (#292) * feat: add create multisig alias page * feat: finalize create msig wallet * Skip camino-wallet-sdk * Added a submodule * update caminojs * Fallback to false on non-browser node modules * Modify webpack fallbacks * fix: update the create multisig wallet component * removal of unecessery console * update the create alias components style * show switch wallet button after the creation of the alias * save msig addresses and names in localStorage * Update en.json * feat: await the saving of the msig in localstorage before form reset --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> * update multisig on network change (#296) * Create/Edit multisig alias (#297) * Edit msig fixes (#298) * fix: update msig infos on pendingtx change * fix: break for if the msigAlias is undefined * fix editing msg with saved keys (#299) * Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301) * fix: optional chaining to various code segments * feat: introduce validation for p-chain addresses * style: adjust colors for add and remove buttons for improved visibility * Msig fixes (#303) * feat: add a custom notification for insufficient funds error * feat: validate the address and disable buttons when needed --------- Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Ayoub Agoumi <[email protected]>
mo-c4t
added a commit
that referenced
this pull request
Sep 14, 2023
* feat: expose the commit hash to the suite (#287) * kyb modal adjustment (#290) * kyb modal adjustment * fix clearing user data before closing disclaimer modal * [Dependencies] Skip camino-wallet-sdk (#291) * Skip camino-wallet-sdk * Fallback to false on non-browser node modules * Modify webpack fallbacks --------- Co-authored-by: Rafail Kordonias <[email protected]> * Adjust settings area styling (#295) * adjust settings area styling * fix clearing user data before closing the disclaimer modal --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> * adjust buildDeposit Tx (#293) Co-authored-by: Achraf Eddaqqaq <[email protected]> * Create multisig alias (#292) * feat: add create multisig alias page * feat: finalize create msig wallet * Skip camino-wallet-sdk * Added a submodule * update caminojs * Fallback to false on non-browser node modules * Modify webpack fallbacks * fix: update the create multisig wallet component * removal of unecessery console * update the create alias components style * show switch wallet button after the creation of the alias * save msig addresses and names in localStorage * Update en.json * feat: await the saving of the msig in localstorage before form reset --------- Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> * update multisig on network change (#296) * Create/Edit multisig alias (#297) * Edit msig fixes (#298) * fix: update msig infos on pendingtx change * fix: break for if the msigAlias is undefined * fix editing msg with saved keys (#299) * Optional Chaining, P-chain Address Validation, and UI Color Adjustments (#301) * fix: optional chaining to various code segments * feat: introduce validation for p-chain addresses * style: adjust colors for add and remove buttons for improved visibility * Msig fixes (#303) * feat: add a custom notification for insufficient funds error * feat: validate the address and disable buttons when needed --------- Co-authored-by: Achraf Eddaqqaq <[email protected]> Co-authored-by: Rafail Kordonias <[email protected]> Co-authored-by: aeddaqqa <[email protected]> Co-authored-by: Ayoub Agoumi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip camino-wallet-sdk