Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a comment for timestamp #48

Merged
merged 2 commits into from
Oct 17, 2024
Merged

add a comment for timestamp #48

merged 2 commits into from
Oct 17, 2024

Conversation

mo-c4t
Copy link
Member

@mo-c4t mo-c4t commented Oct 10, 2024

Add a comment above timestamp whenever it is used in proto files:
"// For any on-chain transactions, if applicable, nanoseconds will be ignored"

@mo-c4t mo-c4t requested a review from havan October 10, 2024 08:02
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-c4t mo-c4t requested a review from havan October 17, 2024 08:31
@mo-c4t mo-c4t merged commit 3864f7f into dev Oct 17, 2024
8 checks passed
@mo-c4t mo-c4t deleted the timestamp-doc branch October 17, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants