Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport list #47

Merged
merged 13 commits into from
Oct 17, 2024
Merged

Transport list #47

merged 13 commits into from
Oct 17, 2024

Conversation

mo-c4t
Copy link
Member

@mo-c4t mo-c4t commented Oct 9, 2024

  • Add transport list service
  • Add schedule for the whole trip in Trip message

Diagram: https://storage.googleapis.com/docs-cmp-files/diagrams/draft/proto/cmp/services/transport/v1/list.proto.dot.xs.svg

@mo-c4t mo-c4t requested a review from havan October 9, 2024 08:47
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments about the new Trip types and some minor typos.

proto/cmp/services/transport/v3/search.proto Outdated Show resolved Hide resolved
proto/cmp/services/transport/v3/trip_types.proto Outdated Show resolved Hide resolved
proto/cmp/services/transport/v3/trip_types.proto Outdated Show resolved Hide resolved
proto/cmp/services/transport/v3/trip_types.proto Outdated Show resolved Hide resolved
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a typo and wrong versions diagram links.

proto/cmp/services/transport/v3/search.proto Outdated Show resolved Hide resolved
proto/cmp/services/transport/v3/search_result_types.proto Outdated Show resolved Hide resolved
proto/cmp/services/transport/v3/search.proto Outdated Show resolved Hide resolved
@mo-c4t mo-c4t requested a review from havan October 17, 2024 13:26
@mo-c4t mo-c4t merged commit 8736680 into dev Oct 17, 2024
8 checks passed
@mo-c4t mo-c4t deleted the transport-list branch October 17, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants