Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v2 diagram links #45

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix v2 diagram links #45

merged 2 commits into from
Sep 24, 2024

Conversation

havan
Copy link
Member

@havan havan commented Sep 24, 2024 •
edited
Loading

This PR:

  • fixes incorrect diagram link in the v2 packages.
  • add an extra line between diagram image and link

Tip

Find all files under matching */v2/*.proto and and replace the v1 in the URL with v2:

find . -type f -path "*/v2/*.proto" -exec sed -E 's#(/)v1(/[^/]*proto\.dot[^)]*\.svg\))#\1v2\2#g' -i {} +

@havan havan requested a review from Noctunus September 24, 2024 16:51
@havan havan merged commit 2808e84 into dev Sep 24, 2024
8 checks passed
@havan havan deleted the ekrem/fix-v2-diagram-links branch September 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noctunus Noctunus Noctunus approved these changes

@mo-c4t mo-c4t mo-c4t approved these changes

@SamJaarsma SamJaarsma Awaiting requested review from SamJaarsma SamJaarsma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@havan @Noctunus @mo-c4t