Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency checker #36

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Dependency checker #36

merged 10 commits into from
Sep 20, 2024

Conversation

Noctunus
Copy link
Member

Added a script which checks the protobuf dependencies and fails if there is something wrong

Noctunus added 2 commits September 19, 2024 23:32
…e latest version of the proto files is used everywhere in the includes and does one additional check if type files are included anywhere.
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Really Good To Me! 🔥

@Noctunus Noctunus merged commit 2c652a7 into dev Sep 20, 2024
6 checks passed
@Noctunus Noctunus deleted the dependency-checker branch September 20, 2024 07:15
mo-c4t pushed a commit that referenced this pull request Sep 20, 2024
* Added dependency checker script. This checks if the latest version of the proto files is used everywhere in the includes and does one additional check if type files are included anywhere.
* Updated workflow to also run the dependency checker script and print out a dependency graph.
* Added --print-graph and --fix parameters to the dependency checker. 
* Added summary at the end of the --fix run to see at a glance all the files which have been added due to the dependency fixes.

---------

Co-authored-by: Noctunus <[email protected]>
mo-c4t pushed a commit that referenced this pull request Sep 20, 2024
* Added dependency checker script. This checks if the latest version of the proto files is used everywhere in the includes and does one additional check if type files are included anywhere.
* Updated workflow to also run the dependency checker script and print out a dependency graph.
* Added --print-graph and --fix parameters to the dependency checker. 
* Added summary at the end of the --fix run to see at a glance all the files which have been added due to the dependency fixes.

---------

Co-authored-by: Noctunus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants