Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buyer address and buyable_until #18

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add buyer address and buyable_until #18

merged 1 commit into from
Apr 16, 2024

Conversation

havan
Copy link
Member

@havan havan commented Apr 16, 2024

This PR:

  • Adds buyer address to the mint request, to be used by the supplier bot while minting the BookingToken on chain. The token should only be buyable by this address.
  • Adds price info to the mint response to be used by the supplier bot while minting the booking token.
  • Adds buyable until into the mint response to be used by the supplier bot to set a expiration timestamp into the token on-chain. It should not be possible to buy the token after this timestamp.
  • Updated booking_timestamp field's name, to better reflect what it is, to provider_booking_timestamp. (It's the timestamp of the booking in the supplier's inventory system)

@havan havan requested a review from SamJaarsma as a code owner April 16, 2024 13:19
@havan havan requested a review from Noctunus April 16, 2024 13:20
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Noctunus Noctunus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havan havan merged commit dfcf343 into dev Apr 16, 2024
3 checks passed
@havan havan deleted the extend-validate-mint branch April 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants