Validate and Mint messages #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamJaarsma
requested changes
Apr 15, 2024
Noctunus
reviewed
Apr 15, 2024
* remove currency field * remove status fields * mv digital asset into a separate message * mv txn id to mint txn id * make result_id a single field instead of a list * rm key field * remove TravellerType from ExtensiveTraveller message * make tags incrementing (fix one missing tag number in ExtensiveTraveller)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validate and mint messages.
Also introduces multiple changes to be used by those messages:
credit_card.proto: Message definition to represent a credit card.payment.proto: Message definition to represent a payment. Options of aoneoffield areon_chainandoff_chain_invoicewithEmptymessage type. And a third option ofoff_chain_vccwith aCreditCardmessage type.pubkey.proto: Message definition to represent a public key. Type of `string'.traveller.proto:ExtensiveTravellermessage type is updated withTravellerTypefield. I think this field was forgotten in previous updates.BasicTravellerhas it butExtensiveTravellerwas missing.