Skip to content

Commit

Permalink
applied review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
SamJaarsma committed Dec 19, 2023
1 parent 99fc4ad commit c8f0843
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 15 deletions.
33 changes: 21 additions & 12 deletions proto/cmp/services/activity/v1alpha1/search_parameters_types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,48 +7,57 @@ import "cmp/types/v1alpha1/time.proto";
import "cmp/types/v1alpha1/price.proto";

// ### Activity Search Parameters
//These are Activity specific search parameters
//
// These are Activity specific search parameters
//
// ![Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/services/activity/v1alpha1/search_parameters_types.proto.dot.xs.svg)
// [Open Message Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/services/activity/v1alpha1/search_parameters_types.proto.dot.svg)
message ActivitySearchParameters {
// Specify the language(s) a potential guide should speak
// for example a tour in the Anne Frank house in Amsterdam in French or the tour at the
// pyramids in Egypt should be in Russian
// Specify the language(s) a potential guide should speak for example a tour in
// the Anne Frank house in Amsterdam in French or the tour at the pyramids in
// Egypt should be in Russian
repeated cmp.types.v1alpha1.Language spoken_language = 1;

// Specify one or more product codes to be included in the search response
// Specify one or more product codes to be included in the search response
//
// Ex: "TC000000"
repeated string product_code = 2;

// Specify one or more activity IDs to be included in the search response
//
// Ex: "EESPMI46VY"
repeated string activity_id = 3;

// Specify one or more service codes to be included in the search response
//
// Ex: "XO"
repeated string service_code = 4;

// Specify one or more category codes to be included in the search response
//
// Ex: "XA"
repeated string category_code = 5;

// Specify one or more type codes to be included in the search response
//
// Ex: "SF"
repeated string type_code = 6;

// Duration
// Specify the minimal and maximum duration of an activity to be included in the search response
//
// Specify the minimal and maximum duration of an activity to be included in the
// search response
cmp.types.v1alpha1.Time min_duration = 7;
cmp.types.v1alpha1.Time max_duration = 8;

// Pricerange
// Specify the minimum and maximum price of an activity to be included in the search response
// Pricerange
//
// Specify the minimum and maximum price of an activity to be included in the
// search response
cmp.types.v1alpha1.Price min_price = 9;
cmp.types.v1alpha1.Price max_price = 10;

// Brandcode
// Specify one or more brand codes or distribution channels for which assigned product is
// to be included in the search response
// Specify one or more brand codes or distribution channels for which assigned
// product is to be included in the search response
repeated string brand_code = 11;
}
}
2 changes: 1 addition & 1 deletion proto/cmp/types/v1alpha1/language.proto
Original file line number Diff line number Diff line change
Expand Up @@ -196,4 +196,4 @@ enum Language {
LANGUAGE_YO = 181; // Yoruba
LANGUAGE_ZA = 182; // "Zhuang, Chuang"
LANGUAGE_ZU = 183; // Zulu
}
}
2 changes: 1 addition & 1 deletion proto/cmp/types/v1alpha1/price.proto
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ message PriceDetail {
message Price {
cmp.types.v1alpha1.Currency currency = 1;
float net = 2;
}
}
2 changes: 1 addition & 1 deletion proto/cmp/types/v1alpha1/time.proto
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ package cmp.types.v1alpha1;
message Time {
int32 hours = 1;
int32 minutes = 2;
}
}

0 comments on commit c8f0843

Please sign in to comment.