Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to account scope for bot add/remove/list #27

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

havan
Copy link
Member

@havan havan commented Sep 11, 2024

This PR:

  • adds tasks for calling addMessengerBot(bot, gasmoney) and addMessengerBot(bot, gasmoney) functions on the CM Accounts.

  • updates --private-key and --cm-account params to be optional and the default value to be taken from process.env.CMACCOUNT_PK or process.env.CMACCOUNT_ADDRESS.

    So the user can just export those env variables and do not provide the params to the task if they are always work with the same CM Account address and PK.

  • Updates sign_primitive.js example script to use verifyCheque function on-chain to compare if the off-chain calculated signature is correct.

@havan havan requested review from Noctunus and mo-c4t and removed request for Noctunus and mo-c4t September 12, 2024 12:28
@havan havan merged commit 74f9948 into dev Sep 12, 2024
4 checks passed
@havan havan deleted the ekrem/bot-tasks branch September 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants