Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published posts bug fixes #3

Closed
wants to merge 7 commits into from
Closed

Conversation

spacedmonkey
Copy link

This is a pretty simple pull request to address some issues #1 #2

Key code changes

  • Ajax only searches for published posts to stop drafts being in collections
  • get_post_collection function now checks if post exists and it published
  • Uses the wp_send_json.

fix https://github.com/TimeIncUK/keystone/issues/382

@spacedmonkey
Copy link
Author

Any chance on getting this merged?

@johnbillion
Copy link
Contributor

This looks sane. I'll test properly tonight.

Aside: You'll probably want to change the Composer URL for this repo in Keystone to your TimeIncUK fork.

@spacedmonkey
Copy link
Author

We already have a workaround for this here https://github.com/TimeIncUK/keystone-theme/commit/30c2d3f6125bdadeb944441bf7b28e626cf39e2e

I would prefer to fix this for everyone anyway. This has been a issue since launch, I can wait for this to be merged.

@spacedmonkey
Copy link
Author

Is there any movement on this? It has been nearly 2 months...

@ghost ghost closed this by deleting the head repository Aug 2, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants