Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use forEach to replace for...of statement #201

Merged
merged 1 commit into from
May 7, 2024

Conversation

hueitan
Copy link
Contributor

@hueitan hueitan commented May 1, 2024

Issue #200
Demo: https://codepen.io/huei90/pen/xxeNmzJ

This PR fix the issue of unexpected behaviour when removing attributes while in the for loop statement, the main difference is render.js file

@cferdinandi
Copy link
Owner

YO! Thank you for the detailed bug report AND issuing a PR!

This makes total sense. the original was a live list, and you're converting it to a static array.

Just going to test on my end, then merge. I appreciate you doing this!

@cferdinandi cferdinandi merged commit f10dea3 into cferdinandi:master May 7, 2024
@cferdinandi
Copy link
Owner

Merged! I updated the version number, and switched back to for...of loops. Converting to an array with Array.from() was the trick. Thanks for figuring that out!

@hueitan
Copy link
Contributor Author

hueitan commented May 7, 2024

Great, thank you for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants