Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to full wasm execution #1881

Closed
wants to merge 1 commit into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jun 20, 2024

Description

Stops using the NativeElseWasmExecutor and replaces it with the WasmExecutor. Thus, block production/import etc is also using the wasm execution as the validation on the relay chain.

Fixes paritytech/polkadot-sdk#4808

Changes and Descriptions

[List your changes here]

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer
Copy link
Collaborator

First of all, thanks a lot for all the effort taken into researching and solving this. I am still not sure I follow the process here:

  • Should we anyways switch to full wasm execution - we could also defer to use the MaxEncodedLen in the feed size?
  • Why is the chain able to make progress?
    *. IIUC the parachain tried to include said extrinsic in the block - events were popping up - but the relay-chain could not validate such block - still block production continued, just without said extrinsic being included.

@bkchr
Copy link
Contributor Author

bkchr commented Jun 20, 2024

  • Should we anyways switch to full wasm execution - we could also defer to use the MaxEncodedLen in the feed size?

Yes you should switch to full wasm execution. This is the future any way and the NativeElseWasmExecutor is tagged as deprecated in master already.

  • Why is the chain able to make progress?
    *. IIUC the parachain tried to include said extrinsic in the block - events were popping up - but the relay-chain could not validate such block - still block production continued, just without said extrinsic being included.

Yeah without the transaction it could progress, because then the mismatch wasn't triggered.

@mustermeiszer mustermeiszer mentioned this pull request Jun 21, 2024
4 tasks
@mustermeiszer
Copy link
Collaborator

Replaced by #1882. All kudos to @bkchr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digest item must match that calculated
2 participants