Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gorgone): when pushing engine conf, push centreon_vmware daemon configuration #1718

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat(gorgone): when pushing engine conf, push centreon_vmware daemon configuration #1718

wants to merge 10 commits into from

Conversation

Evan-Adam
Copy link
Contributor

Description

As we want vault support, the centreon_vmware daemon configuration now have to be managed by the central.
This PR aim to push a centreon_vmware.json conf file to each poller with the vmware authentication configured by the user in the webapp.
This file can contain vault path instead of clear text password, to be decided by the webapp when exporting the conf.
Another ticket aim to upgrade the centreon_vmware daemon to read this file.

Fixes # MON-144643

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

Add an ACC for vmware in the webapp for a poller.
Export the configuration to this poller from the webapplication.
Check on the poller the file /etc/centreon/centreon_vmware.json exist, and contain the correct data configured in the webapp.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Evan-Adam Evan-Adam force-pushed the MON-144643-acc-export-vm-ware-file-on-poller branch 2 times, most recently from 063aae4 to 1bdc8f9 Compare September 23, 2024 16:54
@Evan-Adam Evan-Adam marked this pull request as ready for review September 24, 2024 14:36
@Evan-Adam Evan-Adam requested a review from a team as a code owner September 24, 2024 14:36
@bouda1 bouda1 requested review from a team as code owners September 25, 2024 08:14
@Evan-Adam Evan-Adam force-pushed the MON-144643-acc-export-vm-ware-file-on-poller branch 2 times, most recently from 3eeadac to 37c1df4 Compare September 30, 2024 13:47
@Evan-Adam Evan-Adam force-pushed the MON-144643-acc-export-vm-ware-file-on-poller branch from a386a1a to 34b9492 Compare October 7, 2024 08:26
Evan-Adam and others added 9 commits October 7, 2024 14:49
@Evan-Adam
doc(Gorgone): Add robot tests Readme file
90826a0 
Refs:MON-144643
@Evan-Adam
fix(Gorgone): remove debug log that are too verbose
e6bb79e 
Refs:MON-144643
@kduret @Evan-Adam
fix(ci): update gorgone tests according to packaging distrib change
44627f7
@Evan-Adam
ci(Gorgone): remove bullseye from the test matrix
519aacc 
Refs:MON-144643
@Evan-Adam
feat(Gorgone): allow action module to restart centreon_vmware service.
15c4df4 
Refs:MON-144643
@Evan-Adam
feat(Gorgone): copy centreon_vmware conf file with engine's.
f529aff 
When gorgone receive a message to push the engine configuration (from the centcore file directory) gorgone now also push the centreon_vmware.json file in /etc/centreon/ for the centreon_vmware daemon and restart the daemon while restarting engine.

As centreon_vmware don't support reload, when engine reload we restart centreon_vmware.

Refs:MON-144643
@Evan-Adam
ci(Gorgone): Fix gorgone DB initialization on GHA.
9210d3e 
Add the list of column to insert data into.

Refs:MON-144643
@Evan-Adam
ci(Gorgone): add firsts legacycmd tests
b94c718 
Check gorgone retrieve data from the /var/lib/centreon/centcore/ directory, and send the forced check to the engine pipe.
We use a perl script to mock the pipe, as we don't want to run engine, and gorgone check the file is a real pipe and not a simple file.
Check gorgone push engine, broken and vmware configuration files to the poller, and the poller set the correct path.
Gorgone don't seem to correctly take the configuration modules:engine:command_file. The default /var/lib/centreon-engine/rw/centengine.cmd is used instead, this should be investigated in a separate ticket.
gorgone don't set user/group when processing folder with untar.
create centcore folder in each tests
As www-data don't exist on rpm based distro, we can't test if user/group is correctly set by gorgone.

Refs:MON-144643
@Evan-Adam
tests(Gorgone): separate all tests to use different folder for each t…
4c2ef54 
…ests and update statistic tests to use new version of databaseLibrary.

Refs:MON-144643
@Evan-Adam Evan-Adam force-pushed the MON-144643-acc-export-vm-ware-file-on-poller branch from 1160f10 to 4c2ef54 Compare October 7, 2024 12:53
@Evan-Adam
tests(Gorgone): disable pull tests as they randomly fail.
2438710 
This should be enabled back by the next ticket.
Refs:MON-144643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mushroomempires mushroomempires mushroomempires approved these changes

@sdepassio sdepassio sdepassio approved these changes

@lucie-dubrunfaut lucie-dubrunfaut Awaiting requested review from lucie-dubrunfaut lucie-dubrunfaut is a code owner automatically assigned from centreon/owners-perl

@ddes ddes Awaiting requested review from ddes ddes is a code owner automatically assigned from centreon/owners-pipelines

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 was automatically assigned from centreon/owners-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Evan-Adam @mushroomempires @sdepassio @kduret