MON-130419-CMA_UI_Installer #1715

jean-christophe81 · 2024-09-23T05:34:20Z

Description

Centreon monitoring agent windows installer

REFS:MON-130419

Fixes # (issue)

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

I have followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

coderabbitai · 2024-09-23T05:36:00Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

.github/workflows/windows-agent.yml

agent/installer/centreon-monitoring-agent-modify.nsi

agent/installer/centreon-monitoring-agent.nsi

agent/installer/dlg_helper.nsi

dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: cg-tw <[email protected]>

dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: sechkem <[email protected]> Co-authored-by: cg-tw <[email protected]>

* chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * enh(clib):Remove basic/interruption_error (#1650) * Add pb_neb_lib dependencies to centenginestats * Add pb_bam_lib dependencies to engine_legacy_conf REFS: MON-147186 * no engine_otl_endpoint parameter in telegraf config (#1676) * fix(common/engine_conf): multiple inheritence broken because of a mis… (#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499 * enh(ci): run promote job in dry-run mode on testing branches (#1691) * MON 137835 cma windows robot tests (#1555) * add wsl robot test * fix(engine): host's name instead of template name as alias (#1690) * (fix(engine): host's name instead of template name as alias * fix(Engine): review code REFS: MON-16261 * fix(ci): check PR status from head branch name (#1707) * fix(broker/bbdo):grpc_stream.proto is bad generated (#1713) * fix(broker/bbdo):grpc_stream.proto is bad generated * fix(broker/bbdo): review code REFS: MON- 147911 * fix(ci): legacy conf engine enabled * enh(ci): detect automatically cloud versions (#1712) * fix(broker/neb): fix bbdov2 hostgroup to correctly set enabled flag (#1720) We were not looking for the correct nebtype for updates. * MON-148688-telegraf-certificate-parameters-harmonization (#1716) REFS:MON-148688 * Mon 131997 cma telegraf whitelist (#1723) * telegraf conf_server sues conf_helper * whitelist implementation * add whitelist test * add whitelist test * installer (#1715) dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: sechkem <[email protected]> Co-authored-by: cg-tw <[email protected]> * chore(deps): bump actions/upload-artifact from 4.3.4 to 4.4.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sechkem <[email protected]> Co-authored-by: jean-christophe81 <[email protected]> Co-authored-by: David Boucher <[email protected]> Co-authored-by: Kevin Duret <[email protected]> Co-authored-by: Vincent Untz <[email protected]> Co-authored-by: cg-tw <[email protected]> Co-authored-by: Paul Oureib <[email protected]>

jean-christophe81 changed the title ~~dlg and files installer~~ MON-130419-CMA_UI_Installer Sep 23, 2024

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch from 8031dd1 to 4e1f798 Compare September 23, 2024 05:35

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch 6 times, most recently from b5e6dc3 to 2c8e5e3 Compare September 23, 2024 05:54

bouda1 force-pushed the develop branch from 691b8d2 to 9b5b1c7 Compare September 25, 2024 08:14

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch 19 times, most recently from f8abcee to 949c202 Compare September 27, 2024 07:03

jean-christophe81 marked this pull request as ready for review September 27, 2024 07:08

jean-christophe81 requested review from a team as code owners September 27, 2024 07:08

jean-christophe81 requested review from sdepassio, lucie-dubrunfaut, kduret, mushroomempires and bouda1 September 27, 2024 07:08

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch 3 times, most recently from c6cf61c to bdab145 Compare September 27, 2024 07:20

kduret reviewed Sep 27, 2024

View reviewed changes

.github/workflows/windows-agent.yml Outdated Show resolved Hide resolved

jean-christophe81 requested review from kduret, cg-tw and a team September 27, 2024 08:45

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch 2 times, most recently from 70b12ed to 670132a Compare September 27, 2024 09:35

cg-tw reviewed Sep 27, 2024

View reviewed changes

kduret approved these changes Sep 27, 2024

View reviewed changes

cg-tw approved these changes Sep 27, 2024

View reviewed changes

kduret approved these changes Sep 27, 2024

View reviewed changes

bouda1 approved these changes Sep 27, 2024

View reviewed changes

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch from d6e9815 to 86e18a7 Compare September 30, 2024 05:09

installer

3e8326e

dlg and files installer agent is a windows service add agent version resources first version of installer writer review add installer to CMakeLists.txt add comments Apply suggestions from code review Co-authored-by: cg-tw <[email protected]>

jean-christophe81 force-pushed the MON-130419-CMA_UI_Installer branch from 86e18a7 to 3e8326e Compare September 30, 2024 05:10

jean-christophe81 merged commit 8f4101f into develop Sep 30, 2024
434 of 435 checks passed

jean-christophe81 deleted the MON-130419-CMA_UI_Installer branch September 30, 2024 06:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MON-130419-CMA_UI_Installer #1715

MON-130419-CMA_UI_Installer #1715

jean-christophe81 commented Sep 23, 2024 •

edited

Loading

coderabbitai bot commented Sep 23, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

MON-130419-CMA_UI_Installer #1715

MON-130419-CMA_UI_Installer #1715

Conversation

jean-christophe81 commented Sep 23, 2024 • edited Loading

Description

Type of change

Target serie

How this pull request can be tested ?

Checklist

coderabbitai bot commented Sep 23, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jean-christophe81 commented Sep 23, 2024 •

edited

Loading

coderabbitai bot commented Sep 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)