Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(resources): in detail, fetch downtime only if needed #12032

Open
wants to merge 1 commit into
base: dev-21.10.x
Choose a base branch
from

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Oct 24, 2022

Description

This PR intends to only fetch downtimes for resources if needed !

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

See Jira ticket for this

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@adr-mo adr-mo requested review from a team, a-launois and dmyios and removed request for a team October 24, 2022 08:14
0
);
$resource->setDowntimes($downtimes);
if ($resource->getInDowntime() === true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to rename later getInDowtime by isInDowntime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did not take the time to do it as multiple impacts which are not that mandatory as 21.10 will reach EOL soon

@sonarqube-decoration
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants