Feature image overlay

[andrewgryan]

Early design to add imageOverlay with the intention to easily extend this technique to all other L.* constructors.

Work in progress at the moment.

Summary by CodeRabbit

• New Features

  • Updated createLeafletObject function to include image overlay creation based on provided datasets.
  • Added new functions createL and changeL for handling Leaflet object creation and modification using HTML data attributes.
  • Added support for ImageOverlay attributes in Hyperleaflet, enabling easy creation with specific data attributes.

• Documentation

  • Detailed specifications for data-l, data-image-url, and data-image-bounds attributes provided in the usage documentation.
  • Event handling system in Hyperleaflet now supports map and geometries interaction with custom events sent to the window object.

[coderabbitai]

Warning

Rate Limit Exceeded

@andrewgryan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 33 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 8e530f3 and a4cb491.

Walkthrough

The latest update enriches geometry-related operations in a web mapping application. It enhances data handling in hyperleaflet functions, incorporates new HTML attributes for improved filtering, and extends Leaflet object management to support image overlays alongside geometric shapes.

Changes

Files	Changes Summary
.../hyperleaflet-geometry-handler.js & .../index.js	Enhanced data handling and attribute filtering, including direct access to rowId and new HTML data attributes.
.../Geometry/leaflet-geometry.js & .../Geometry/test/hyperleaflet-geometry-handler.test.js	Updated createLeafletObject with image overlay check, added createL and changeL functions, and included test cases for Leaflet imageOverlay creation and modification.

Poem

🐰🌌
Where code meets map, a rabbit's dance,
Geometry whispers, a new chance.
Image overlays, a digital delight,
Testing boundaries in the starry night.
Celebrate changes, in maps we play,
Forever hopping, in the coding way! 🗺️🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 3

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 3

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[andrewgryan]

@cemrehancavdar this is ready for review. I cherry picked a commit from #42 to patch the change handler mechanism in an identical manner to prevent merge conflicts. I avoided adding support for data-options here as I think that should be a general feature of the library and #42 has added some support for it already.