WIP: overrides the timeout_commit and timeout_propose in v3 #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcstein
reviewed
Oct 10, 2024
| @@ -30,7 +30,7 @@ const ( | |||
| // DefaultUpgradeHeightDelay is the number of blocks after a quorum has been | |||
| // reached that the chain should upgrade to the new version. Assuming a block | |||
| // interval of 12 seconds, this is 7 days. | |||
| DefaultUpgradeHeightDelay = int64(7 * 24 * 60 * 60 / 12) // 7 days * 24 hours * 60 minutes * 60 seconds / 12 seconds per block = 50,400 blocks. | |||
| DefaultUpgradeHeightDelay = 3 // int64( 7 * 24 * 60 * 60 / 12) // 7 days * 24 hours * 60 minutes * 60 seconds / 12 seconds per block = 50,400 blocks. | |||
There was a problem hiding this comment.
Suggested change
| DefaultUpgradeHeightDelay = 3 // int64( 7 * 24 * 60 * 60 / 12) // 7 days * 24 hours * 60 minutes * 60 seconds / 12 seconds per block = 50,400 blocks. | |
| DefaultUpgradeHeightDelay = 3 // int64( 7 * 24 * 60 * 60 / 6) // 7 days * 24 hours * 60 minutes * 60 seconds / 6 seconds per block = 100,800 blocks. |
jcstein
reviewed
Oct 10, 2024
| @@ -274,8 +274,8 @@ func DefaultConsensusConfig() *tmcfg.Config { | |||
| cfg.Mempool.MaxTxsBytes = int64(upperBoundBytes) * cfg.Mempool.TTLNumBlocks | |||
There was a problem hiding this comment.
Should line 146 have this?
// time. The expected block time is 6 seconds, therefore this value is 30
|
Should Linking discussion from my PR which I plan to close: https://github.com/celestiaorg/celestia-app/pull/3953/files#r1794435786 |
jcstein
reviewed
Oct 10, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| # Stop script execution if an error is encountered | |||
| set -o errexit | |||
| # Stop script execution if an undefined variable is used | |||
| # Stop scyript execution if an undefined variable is used | |||
There was a problem hiding this comment.
Suggested change
| # Stop scyript execution if an undefined variable is used | |
| # Stop script execution if an undefined variable is used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3859 though is in progress!