Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub actions CI #359

Merged
merged 3 commits into from
Mar 7, 2021
Merged

Added GitHub actions CI #359

merged 3 commits into from
Mar 7, 2021

Conversation

matusvalo
Copy link
Member

@matusvalo matusvalo commented Mar 4, 2021

This PR Adds 1:1 replacement of Travis CI with GitHub actions.

@matusvalo
Copy link
Member Author

Next step is kombu...

@auvipy
Copy link
Member

auvipy commented Mar 5, 2021

Next step is kombu...

you can improve celery/kombu#1299

- name: Install dependencies
run: pip install --upgrade pip setuptools wheel tox tox-docker
- name: Run unittest
run: tox -v -e ${{ matrix.python-version }}-unit -- -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I first tried using tox integration tests in celery took so long time that I had to try other options. good to see it working good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes GitHub actions are pretty fast.

@matusvalo
Copy link
Member Author

Can we merge even this PR? Are there any objections @auvipy @thedrow ?

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can improve as we go.

@auvipy auvipy merged commit 4eb39c6 into celery:master Mar 7, 2021
@matusvalo matusvalo deleted the github_actions branch March 7, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants