Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made an MVVM friendly example. #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Made an MVVM friendly example. #30

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4da1fe4
Made an MVVM friendly example.
Oct 27, 2016
f95ffac
Fixed the Behavior calling reference.
Oct 28, 2016
d9de214
Removed C#6.0 features.
Oct 28, 2016
c40ba36
Fixed the Behavior.
Oct 28, 2016
a6da190
Changed the Blend Behavior to an Attached Property Behavior.
Oct 28, 2016
da924cc
Improved the LoadHtml validation logic.
Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CefSharp.MinimalExample.Wpf/Binding/Behaviors/BindHtmlAttachedBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ private static void OnHtmlChanged(DependencyObject d, DependencyPropertyChangedE
{
return;
}

(d as ChromiumWebBrowser)?.LoadHtml((string)e.NewValue, "http://test/page");
(d as LoadHtmlBehavior)?.AssociatedObject.LoadHtml((string)e.NewValue, "about:blank");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HtmlUrl property isn't being used. Also best not o use about:blank, as it's a special case. You'd be effectively registering a ResourceHandler that gets loaded every time about:blank is required.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...so "http://test/page" is a better fit?

Should we add a new method to load an HTML directly through one parameter?

Could you explain me briefly the intent of the LoadHtml with an URL?

}
}
}