Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update atomic dependency #95

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jul 22, 2024

This required adding a bytemuck::Pod requirements to the CustomFloat trait. Given the description of the trait, the requirement seems reasonable.

@imrn99 imrn99 marked this pull request as ready for review July 24, 2024 14:08
@imrn99 imrn99 changed the title chore: update atomic dependency chore!: update atomic dependency Jul 24, 2024
@cedricchevalier19
Copy link
Member

What is the goal of this bytemuck addition?

@imrn99
Copy link
Collaborator Author

imrn99 commented Jul 26, 2024

What is the goal of this bytemuck addition?

This is a requirement induced by the new atomic version. From their docs:

This library defines a generic atomic wrapper type Atomic for all T: NoUninit types. Atomic types present operations that,
when used correctly, synchronize updates between threads.

The NoUninit bound is from the bytemuck crate, and indicates that a type has no internal padding bytes. You will need to
derive or implement this trait for all types used with Atomic.

@cedricchevalier19 cedricchevalier19 merged commit 3a84104 into main Jul 26, 2024
4 checks passed
@imrn99 imrn99 deleted the update-atomic-rs branch July 28, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants