feat(rds): add support for Aurora Serverless Clusters #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeung-amzn
changed the title
zqumei0
force-pushed
the
feat/aurora_monitoring
branch
from
5e9ae90
to
db5f8dd
Compare
zqumei0
commented
Sep 30, 2023
There was a problem hiding this comment.
@echeung-amzn Curious if you have any thoughts on this guard. Not sure how to properly implement this.
echeung-amzn
reviewed
Oct 2, 2023
|
This looks really good, anything I can do to help get this merged? 🙏🏻 |
|
Sorry for late response been busy with some other stuff! I just got the changes in and I will push it tonight for review (and hopefully approval). |
zqumei0
force-pushed
the
feat/aurora_monitoring
branch
from
db5f8dd
to
ddf6310
Compare
echeung-amzn
requested changes
Nov 9, 2023
Added new AuroraCluster Monitoring with Aurora specific metrics/alarms.
zqumei0
force-pushed
the
feat/aurora_monitoring
branch
from
ddf6310
to
aa9be3e
Compare
echeung-amzn
approved these changes
Nov 9, 2023
|
@zqumei0 @echeung-amzn thank you for getting this merged, I really appreciate you taking time to get this shipped 🚀 We have just started using these constructs and they are helping us build dashboards and alerts quickly. |
|
Amazing, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new AuroraCluster Monitoring with Aurora specific metrics/alarms.
Fixes #217
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license