Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form issues on goal forms #127

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Fix form issues on goal forms #127

merged 1 commit into from
Mar 12, 2015

Commits on Mar 12, 2015

  1. Fix form issues on goal forms 

    Pagetree's auto-generated <form> tag has a few problems preventing
me from using it with the goal forms:

* After submitting an invalid form, Pagetree's Submit button disappears,
preventing the user from being able to submit the form again.
* The "change my answers" form isn't compatible with formsets. See
ccnmtl/django-pagetree#58

My solution is to again have the pageblock render its own <form>. This
necessitates an unfortunate hack: hiding pagetree's Submit button with
JavaScript. This is one of the reasons I think needs_submit should be
broken out into two different configurable params: Something like
`handles_post_data` and `renders_form`. Related to issue here:
ccnmtl/django-pagetree#44
    @nikolas
    nikolas committed Mar 12, 2015
    Configuration menu
    Copy the full SHA
    a059800 View commit details
    Browse the repository at this point in the history