fix some bugprone-macro-parentheses warnings #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not even compile. |
ChristianTackeGSI
force-pushed
the
pr/fix_bugprone
branch
from
b6c79d5
to
427eb8d
Compare
|
Okay, in my first attempt this used to compile. Now it also fails. Anyway: I have stripped this down to the part that does compile and also gives a successful |
ChristianTackeGSI
force-pushed
the
pr/fix_bugprone
branch
from
427eb8d
to
1852fcf
Compare
Codecov Report
@@ Coverage Diff @@
## devel #2732 +/- ##
==========================================
+ Coverage 91.36% 91.37% +0.01%
==========================================
Files 190 190
Lines 7855 7855
==========================================
+ Hits 7176 7177 +1
+ Misses 679 678 -1 |
|
Thanks, I'll take a look.
I suspect that you didn't have test build enabled, and because the main library doesn't exercise those macros, breaking them won't stop it from compiling. |
|
Is there anything left, that I forgot about? |
|
You haven't forgotten about anything, I did forget about the PR though. |
horenmar
reviewed
Sep 17, 2023
horenmar
reviewed
Sep 17, 2023
When using the public headers of catch2 in another project that uses clang-tidy with some checks enabled, then some warnings in catch2's headers are also reported. This fixes a bunch of bugprone-macro-parentheses warnings. See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html
ChristianTackeGSI
force-pushed
the
pr/fix_bugprone
branch
from
1852fcf
to
1d03457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the public headers of catch2 in another project that uses clang-tidy with some checks enabled, then some warnings in catch2's headers are also reported. Those can distract from the real problem in our project. So I would like to reduce the warnings from catch2.
This fixes a bunch of bugprone-macro-parentheses warnings.
See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html
GitHub Issues
None