Redact SignedData and EnvelopedData toString by default and expose helper methods for unredacted values #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinsee
changed the title
brunofrts
reviewed
Feb 27, 2024
brunofrts
reviewed
Feb 27, 2024
…per methods for unredacted values
alvinsee
force-pushed
the
alvin/trifle-redact
branch
from
0907af5
to
f957877
Compare
brunofrts
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defaults toString methods to redact the data field as it might contain sensitive information. This PR also exposes a secondary method in the scenario that developers would want to print data in plaintext.