Generate tag for keyhandles instead of parameterization of aliases #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadphly
reviewed
Sep 28, 2023
gadphly
reviewed
Sep 28, 2023
gadphly
reviewed
Sep 28, 2023
gadphly
reviewed
Sep 28, 2023
|
Since this is a breaking change, let's make sure it's specified clearly in the comments and the release info. |
gadphly
approved these changes
Sep 28, 2023
alvinsee
force-pushed
the
alvin/trifle-android-uuid
branch
from
1dd2c72
to
f2daecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To keep consistency between iOS and Android APIs, this PR removes the parameterization of an alias for the underlying keypair that is to be generated. Instead, clients would initialize a TrifleApi instance with a desired reverse domain name which is prefixed along with a uuid which is suffixed as part of the generated tag.