Break up Certificate#verify to top level Trifle APIs in android sdk #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
from
96cd4ed
to
03a3fc5
Compare
|
This PR looks like it's doing more than allowing nullable params? |
gadphly
approved these changes
Aug 24, 2023
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
from
03a3fc5
to
4a109bf
Compare
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
from
4a109bf
to
dcc1d6e
Compare
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
from
dcc1d6e
to
12c863d
Compare
alvinsee
changed the title
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
2 times, most recently
from
91af594
to
5d432c3
Compare
alvinsee
force-pushed
the
alvin/trifle-jvm-verify-2
branch
from
5d432c3
to
50888bd
Compare
jvm/src/main/kotlin/app/cash/trifle/validators/CertificateValidatorFactory.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaks up
Certificate#verifyto the follow top level APIs:TrifleApi.verifyChain(List<Certificate>, Certificate?, Date?): Result<Unit>TrifleApi.verifyValidity(Certificate, Date?): Result<Unit>TrifleApi.verifyAttributes(Certificate, CertificateRequest): Result<Unit>