update client cert TTL to 30 days instead of 180 (#146)

* update client cert TTL to 30 days instead of 180
cashapp · Jul 13, 2023 · 85a4473 · 85a4473
1 parent 74b2d19
commit 85a4473
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -1,5 +1,5 @@
 [libraries]
-android-gradle-plugin = { module = "com.android.tools.build:gradle", version = "7.4.2" }
+android-gradle-plugin = { module = "com.android.tools.build:gradle", version = "7.4.0-beta02" }
 dokka-gradle-plugin = { module = "org.jetbrains.dokka:dokka-gradle-plugin", version = "1.7.20" }
 mavenPublish-gradle-plugin = { module = "com.vanniktech:gradle-maven-publish-plugin", version = "0.23.2" }
 kotlin-gradle-plugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version = "1.7.10" }

diff --git a/jvm/src/main/kotlin/app/cash/trifle/CertificateRequest.kt b/jvm/src/main/kotlin/app/cash/trifle/CertificateRequest.kt
@@ -30,10 +30,8 @@ sealed interface CertificateRequest {
   companion object {
     internal const val MOBILE_CERTIFICATE_REQUEST_VERSION: Int = 0
 
-    // Validity time for device-certificate, currently scoped to 180 days, based entirely on
-    // intuition. This is not currently used, and should be configurable by the client when usage is
-    // desired.
-    internal const val MOBILE_CERTIFICATE_VALIDITY_PERIOD_DAYS: Int = 180
+    // Validity time for device-certificate, currently scoped to 30 days
+    internal const val MOBILE_CERTIFICATE_VALIDITY_PERIOD_DAYS: Int = 30
 
     /**
      * Converts the given serialized MobileCertRequest into a CertificateRequest. This enables clients

diff --git a/jvm/src/test/kotlin/app/cash/trifle/TrifleTest.kt b/jvm/src/test/kotlin/app/cash/trifle/TrifleTest.kt
@@ -85,7 +85,7 @@ internal class TrifleTest {
             .minusMillis(certHolder.notBefore.toInstant().toEpochMilli())
             .toEpochMilli()
         )
-      assertEquals(180, duration.toDays())
+      assertEquals(30, duration.toDays())
     }
 
     @Test