Use compileOnly for kotlin/agp plugins #648
Conversation
| @@ -10,7 +10,7 @@ buildscript { | |||
|
|
|||
| dependencies { | |||
| classpath libs.plugin.kotlin | |||
| classpath libs.plugin.android | |||
| classpath 'com.android.tools.build:gradle:7.3.1' | |||
There was a problem hiding this comment.
Not sure if this change was intented? 7.4-rc1 is in the toml.
/paparazzi/build.gradle and your new compileOnly still uses the 7.4 so you might get overridden.
There was a problem hiding this comment.
I have a feeling this was him testing the solution.
See the last classpath below and https://github.com/cashapp/paparazzi/blob/master/settings.gradle#L9 where that plugin is being replaced.
There was a problem hiding this comment.
I think I understand this more now. As I ran into an issue with this.
The the paparazzi-gradle-plugin can use the latest version, but for testing and building the paparazzi AAR an older version can be used.
@jrodbx I suggest splitting it into 3:
libs.plugin.android.build(for AAR build)libs.plugin.android.test(for integration tests)libs.plugin.android.api(for dependency)
The api should be behind a bit (stable), the build can be the latest alpha, and the test is the best compatible version.
jrodbx
force-pushed
the
jrod/2022-12-07/compileOnly
branch
from
524be48
to
581a1ed
Compare
| implementation libs.plugin.kotlin | ||
| implementation libs.plugin.android |
There was a problem hiding this comment.
please merge this PR, I can't use Android Studio Dolphin with 1.2.0-SNAPSHOT, because AS-D doesn't support 7.4:
The project is using an incompatible version (AGP 7.4.0-rc01) of the Android Gradle plugin. Latest supported version is AGP 7.3.1
See Android Studio & AGP compatibility options.
I'm not even sure of a workaround yet, because I'm using plugins {} so there's no classpath(...) { exclude }.
There was a problem hiding this comment.
Tried this, but it doesn't apply transitively and I don't want to list all modules:
buildscript {
configurations.classpath.configure {
resolutionStrategy {
force(libs.android.gradle)
force(libs.android.lint.common)
}This crazy hack works 🤦♂️:
buildscript {
configurations.classpath.configure {
resolutionStrategy {
eachDependency {
if (requested.version == "30.4.0-rc01") {
useVersion("30.3.1")
}
if (requested.version == "7.4.0-rc01") {
useVersion("7.3.1")
}
}
}
}
}
|
Looks like this PR is superseded by -> |
No description provided.