Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the code to get the path of a golden snapshot #1322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BraisGabin
Copy link

Righ now at paparazzi there are 3 different implementations to get the path of a golden snapshot. They are equivalent but their implementations are different. That makes them easy to unsync and that if you need that path in other places you need to reimplement it.

This PR fixes that moving all the logic to a single extension funcion and adding tests to avoid regressions (those paths didn't have any test).

The reason of this PR is because it is needed for #902 and #917. I assume that moving this to a separate PR will make it easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant