Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gradle test logging #3361

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Improve gradle test logging #3361

merged 2 commits into from
Jul 10, 2024

Conversation

rainecp
Copy link
Collaborator

@rainecp rainecp commented Jul 10, 2024

This adds a new property misk.test.logging to enable or disable certain logging features. By default, it will be set to false to reduce the amount of logs.

build.gradle.kts Outdated Show resolved Hide resolved
Co-authored-by: Andrew (Paradi) Alexander <[email protected]>
@rainecp rainecp merged commit bdb855c into master Jul 10, 2024
14 checks passed
@rainecp rainecp deleted the raine/test-logging branch July 10, 2024 19:13
@@ -4,3 +4,4 @@ org.gradle.caching=true
org.gradle.vfs.watch=true
org.gradle.configureondemand=true
org.gradle.parallel=true
misk.test.logging=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the new line in this file broke publishing, fix incoming.

svc-squareup-copybara pushed a commit that referenced this pull request Jul 11, 2024
![Screenshot 2024-07-11 at 15 48
57](https://github.com/squareup/cash-server/assets/8827217/05671a9f-6e58-4ed3-b9fd-32dab083c96c)

This should fix a regression introduced in
#3361

Note the version in the logs is not on a new line so isn't parsed
correctly during the publish step.

GitOrigin-RevId: 367f11cd20d6b7f96195d74e7e33b56a0a798d98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants