Skip to content

Commit

Permalink
Use non-shaded version of hikari
Browse files Browse the repository at this point in the history
We were accidentally using the shaded version of hikari. We shouldn't be
doing this anyway but also this dep is removed in Gradle 8.9. This PR
switches us to using the proper hikari dep.

GitOrigin-RevId: 1cc0fde67e9638e144e43b842379b4d4682dc4d8
  • Loading branch information
yissachar authored and svc-squareup-copybara committed Jul 15, 2024
1 parent f27b257 commit 2a91754
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions misk-schema-migrator-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ dependencies {

testImplementation(gradleTestKit())
testImplementation(libs.assertj)
testImplementation(libs.hikariCp)
testImplementation(libs.junitApi)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package misk.gradle.schemamigrator

import com.zaxxer.hikari.HikariConfig
import com.zaxxer.hikari.HikariDataSource
import org.assertj.core.api.Assertions.assertThat
import org.gradle.internal.impldep.com.zaxxer.hikari.HikariConfig
import org.gradle.internal.impldep.com.zaxxer.hikari.HikariDataSource
import org.gradle.testkit.runner.GradleRunner
import org.gradle.testkit.runner.TaskOutcome
import java.io.File
Expand Down

0 comments on commit 2a91754

Please sign in to comment.