This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Unified outputs #53
Closed
Unified outputs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidanoli
added
feature
guidanoli
force-pushed
the
feature/output-unification
branch
from
4d7c48c
to
5971063
Compare
guidanoli
force-pushed
the
feature/output-unification
branch
from
5971063
to
bd08bc9
Compare
guidanoli
force-pushed
the
feature/output-unification
branch
from
bd08bc9
to
8a0b258
Compare
guidanoli
force-pushed
the
feature/output-unification
branch
from
8a0b258
to
f954082
Compare
BREAKING CHANGE: This commit removes constants `VOUCHER_METADATA_LOG2_SIZE`, `NOTICE_METADATA_LOG2_SIZE`, `EPOCH_VOUCHER_LOG2_SIZE`, and `EPOCH_NOTICE_LOG2_SIZE` from the `CanonicalMachine` library; and parameters `outputEpochLog2Size` and `outputHashesLog2Size` from the `validateEncodedOutput` function in `LibOutputValidation`.
* Outputs are now encoded like Solidity function calls. Notices are like function calls to `Notice(bytes)`, and vouchers, to `Voucher(address,bytes)`. BREAKING CHANGE: Changes the encoding of outputs.
* The epoch hash used to be composed by three Merkle trees: one for the vouchers generated in the epoch, another for the notices generated in the epoch, and a third one for the machine address space as a whole. This commit unifies vouchers and notices in the same Merkle tree, making the epoch hash composed now of only two Merkle trees: one for the outputs generated in the epoch, and another for the machine. * The leaves of this new tree represent any type of output: voucher, notice, or any other output that we might come up with in the future. Their binary representations are disjoint because of a 4-byte header. * This unification greatly simplifies the output validation algorithm, and removes a 256-bit field from the `OutputValidityProof` struct. * Add text to `LibOutputValidation` that explains how the epoch hash is calculated, with the help of an ASCII diagram BREAKING CHANGE: Removes fields `vouchersEpochRootHash` and `noticesEpochRootHash` from the `OutputValidityProof` struct, and adds `outputsEpochRootHash`. Changes the epoch hash calculation.
* In order to test the changes made to the output validation library, a workaround was implemented that uses the notice tree as the output tree for the new algorithm. This workaround is temporary and should be replaced when a new version of the echo machine is made available.
guidanoli
force-pushed
the
feature/output-unification
branch
from
f954082
to
93bbd02
Compare
|
Rebased. |
|
This PR has been migrated to cartesi/rollups-contracts#43. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.