-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/local devnet #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it simple and keep only anvil.
3bd0bf7
to
ae8f4ac
Compare
d065333
to
22dbeba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asked for some changes on my last review comments
squash the fixups |
cec6bfb
to
f637905
Compare
614dc3d
to
dae04be
Compare
/close #14 We can use the command below to test the graphql-server connectivity after install the release. helm test $RELEASE_NAME In CI, the |
1263571
to
81e4386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing missing is the labels:
empty line, I've left a suggestion on how to solve it.
81e4386
to
98ab978
Compare
Fixed the problem ! |
4900119
to
4fdc5a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that this PR entres the next release, you should target the branch feature/rollups-1.0.0
.
There, I already split the deployment.yaml
in 3 different files.
This PR is older than the I think it would be better if we close this PR and then sync the What do U think ? |
Whatever is easy for you. We decided that devnet should go into release 1.0.0, even if it's still a draft, we'll only release 1.0.0 when everything is working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to squash the fixups and remote DELETE
commits.
The version/revision will be tackled on a release commit, let's keep the commit into next
branch generic and without version information
Maybe this next
branch strategy won't work here because of the way ct makes releases and checks for changes between branches, IDK.
I'll assume that we can change the next
history before a final merge into main
.
534c72a
to
7d13f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last commit comment is DOC:
when it should be doc:
, lowercase.
206bdd9
to
d8ad150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could reduce the depth for the validator.localnode.anvil
removing the .anvil
element.
validator.localnode
should be enough, and the use of anvil
would be an "implementation detail¨, so that if the user changes valiator.localnode.
parameters, they can change to hardhat or whatever, for ex., and adapt where is needed.
I think it's not a good solution. because we have lots of dependencies like initcontainers based on anvil. So, we may have other localnodes in future like hardhat. I think we should not change the structure. |
5b27243
to
7c82cbf
Compare
/close #8
/close #14
This PR will deploy rollups nodes along with anvil local node.