Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring cacheControl via s3fs.request.header.cache-control flag #711

Merged
merged 7 commits into from
May 30, 2023

Conversation

steve-todorov
Copy link
Collaborator

Pull Request Description

This pull request closes #690.

Acceptance Test

  • Building the code with gradle clean build still works.

Questions

  • Does this pull request break backward compatibility?

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

@steve-todorov

This comment was marked as outdated.

@steve-todorov
Copy link
Collaborator Author

/deploy-pr

@github-actions
Copy link
Contributor

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-711-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

Copy link
Owner

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! :)

@steve-todorov steve-todorov merged commit f1cb117 into master May 30, 2023
@steve-todorov steve-todorov deleted the feature/690 branch May 30, 2023 22:43
@github-actions github-actions bot mentioned this pull request May 30, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring cacheControl via s3fs.request.header.cache-control flag
2 participants