Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring cacheControl via s3fs.request.header.cache-control flag #690

Closed
1 task done
steve-todorov opened this issue May 12, 2023 · 2 comments · Fixed by #711
Closed
1 task done

Allow configuring cacheControl via s3fs.request.header.cache-control flag #690

steve-todorov opened this issue May 12, 2023 · 2 comments · Fixed by #711
Assignees

Comments

@steve-todorov
Copy link
Collaborator

steve-todorov commented May 12, 2023

Task Description

We need to have a header cache control configuration flag to allow users more flexibility.

Use case

  1. Initial upload of /my/path/object
  2. File is changed and is re-uploaded to /my/path/object - cache causes the file update to be skipped.

Also some proxies might cache requests if Cache-Control header is not present.

Tasks

The following tasks will need to be carried out:

  • Implement the solution (if necessary add configuration flags)

Task Relationships

This task:

Useful Links

Help

@steve-todorov steve-todorov self-assigned this May 12, 2023
steve-todorov added a commit that referenced this issue May 12, 2023
steve-todorov added a commit that referenced this issue May 12, 2023
steve-todorov added a commit that referenced this issue May 12, 2023
steve-todorov added a commit that referenced this issue May 12, 2023
@steve-todorov
Copy link
Collaborator Author

steve-todorov commented May 12, 2023

@szimon could you please have a look at this test case. I'm trying to reproduce your problem without luck. Could you please maybe write a test case that shows your cache problem or articulate steps to reproduce?

Are you, perhaps, using CloudFront in addition to your S3 bucket and maybe need to configure the Cache-Control metadata added to the uploaded file?

@steve-todorov
Copy link
Collaborator Author

@szimon ping? :)

steve-todorov added a commit that referenced this issue May 25, 2023
steve-todorov added a commit that referenced this issue May 25, 2023
steve-todorov added a commit that referenced this issue May 25, 2023
@steve-todorov steve-todorov changed the title Add cache configuration flag Allow configuring cacheControl via s3fs.request.header.cache-control flag May 25, 2023
steve-todorov added a commit that referenced this issue May 25, 2023
steve-todorov added a commit that referenced this issue May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant