Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use certificates for trust management #26

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Oct 8, 2024

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.11%. Comparing base (f8b5760) to head (0bfb5de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...carbynestack/httpclient/X509TrustManagerUtils.java 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     88.05%   88.11%   +0.05%     
  Complexity       67       67              
============================================
  Files             8        8              
  Lines           201      202       +1     
  Branches         16       16              
============================================
+ Hits            177      178       +1     
  Misses           20       20              
  Partials          4        4              
Files with missing lines Coverage Δ
...ynestack/httpclient/CompositeX509TrustManager.java 84.00% <100.00%> (ø)
.../java/io/carbynestack/httpclient/CsHttpClient.java 87.87% <100.00%> (-0.59%) ⬇️
...ynestack/httpclient/ExtendedSSLContextBuilder.java 100.00% <ø> (ø)
...carbynestack/httpclient/X509TrustManagerUtils.java 94.44% <88.88%> (+2.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b5760...0bfb5de. Read the comment docs.

@sbckr sbckr requested a review from strieflin October 8, 2024 07:14
@strieflin
Copy link
Member

Hi @sbckr, can you please provide a little bit of context? What is the purpose of this PR?

@sbckr
Copy link
Member Author

sbckr commented Oct 8, 2024

@strieflin
Some functionality was made public such that it can be re-used by other modules like the cli, which does not use the java-http-client directly but requires support for self-signed certificates too.
While doing so, I changed the implementation so that it can "consume" certificates directly instead of requiring to be provided JKS KeyStores. Modules using this functionality previously had to create a KeyStore containing the provided certificates first, writing it to a (temporary) file to then provide it to this library. This is somewhat inconvenient, unnecessary, and sometimes worked (for some reasons) unreliably.

Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit e9e5bca into master Oct 8, 2024
9 of 10 checks passed
@sbckr sbckr deleted the harmonize-trust-management branch October 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants