Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service/java-client): add support for partial builds using codeco… #52

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

strieflin
Copy link
Member

…v flags

@strieflin strieflin requested a review from a team as a code owner July 27, 2023 06:33
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #52 (bfe8dc1) into master (63e9250) will increase coverage by 1.65%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     79.65%   81.30%   +1.65%     
- Complexity        0       24      +24     
============================================
  Files            32       34       +2     
  Lines          3101     3055      -46     
  Branches          0       10      +10     
============================================
+ Hits           2470     2484      +14     
+ Misses          556      485      -71     
- Partials         75       86      +11     
Flag Coverage Δ
java-client 85.71% <ø> (?)
service 81.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2610...bfe8dc1. Read the comment docs.

@strieflin strieflin force-pushed the use-codecov-flags branch 3 times, most recently from 001ddce to e352108 Compare July 27, 2023 07:13
@strieflin strieflin force-pushed the use-codecov-flags branch 2 times, most recently from 9bf5595 to 36edc4a Compare July 27, 2023 09:57
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strieflin strieflin merged commit 5a7a591 into master Jul 27, 2023
10 checks passed
@strieflin strieflin deleted the use-codecov-flags branch July 27, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants