Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attach cli artifact to release #38

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: attach cli artifact to release #38

merged 1 commit into from
Aug 4, 2023

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Aug 4, 2023

No description provided.

@sbckr sbckr requested a review from a team as a code owner August 4, 2023 08:11
@sbckr sbckr marked this pull request as draft August 4, 2023 08:11
@sbckr sbckr force-pushed the fix/append-jar-to-release branch from 50f80dd to 0dcc46e Compare August 4, 2023 08:12
@sbckr sbckr marked this pull request as ready for review August 4, 2023 08:13
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #38 (7977c82) into master (5729093) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     83.32%   83.32%           
  Complexity      388      388           
=========================================
  Files            69       69           
  Lines          1463     1463           
  Branches         75       75           
=========================================
  Hits           1219     1219           
  Misses          193      193           
  Partials         51       51

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5729093...7977c82. Read the comment docs.

@sbckr sbckr force-pushed the fix/append-jar-to-release branch from 0dcc46e to 9272ac1 Compare August 4, 2023 08:19
@sbckr
fix: attach cli artifact to release
7977c82 
Signed-off-by: Sebastian Becker <[email protected]>
@sbckr sbckr force-pushed the fix/append-jar-to-release branch from 9272ac1 to 7977c82 Compare August 4, 2023 08:20
strieflin
strieflin approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 50aa988 into master Aug 4, 2023
5 checks passed
@sbckr sbckr deleted the fix/append-jar-to-release branch August 4, 2023 08:22
This was referenced Aug 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strieflin strieflin strieflin approved these changes

Assignees

@strieflin strieflin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbckr @strieflin