Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade amphora to enable secure tuple provisioning #36

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Aug 1, 2023

No description provided.

@sbckr sbckr requested a review from a team as a code owner August 1, 2023 05:33
@sbckr sbckr force-pushed the feat/use-secure-tuple-provisioning branch from 4549047 to 02217b2 Compare August 1, 2023 05:34
@sbckr sbckr force-pushed the feat/use-secure-tuple-provisioning branch from 02217b2 to d5619bc Compare August 1, 2023 05:36
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #36 (30c5124) into master (90fefcc) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage     83.32%   83.32%           
  Complexity      388      388           
=========================================
  Files            69       69           
  Lines          1463     1463           
  Branches         75       75           
=========================================
  Hits           1219     1219           
  Misses          193      193           
  Partials         51       51           
Files Changed Coverage Δ
...ommand/GetSecretAmphoraClientCliCommandRunner.java 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fefcc...30c5124. Read the comment docs.

@sbckr sbckr changed the title upgrade amphora to enable secure truple provisioning feat: upgrade amphora to enable secure truple provisioning Aug 1, 2023
@sbckr sbckr changed the title feat: upgrade amphora to enable secure truple provisioning feat: upgrade amphora to enable secure tuple provisioning Aug 1, 2023
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit ef3c90f into master Aug 1, 2023
6 checks passed
@sbckr sbckr deleted the feat/use-secure-tuple-provisioning branch August 1, 2023 11:15
@cs-minion cs-minion mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants