Update plugin-level citation comment #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcaporaso
reviewed
Sep 3, 2024
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/plugin_setup.py
Outdated
Show resolved
Hide resolved
gregcaporaso
reviewed
Sep 3, 2024
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/plugin_setup.py
Outdated
Show resolved
Hide resolved
|
@nbokulich, thanks for the edits! This is ready to go, but just noticed an issue with q2lint that we need to address. I'm going to leave this open so we can confirm that the q2lint fix works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments about citing the dev docs seem a bit strange in the template. This is something that developers who use this template should cite in their repo and any article(s) as a template for their plugin.
But a plugin-level citation then passes this on to the users; so the comment about keeping this plugin-level citation implies that all users of that plugin should also be citing the dev docs. This does not seem appropriate, as the users did not use the dev docs in their research.
Discussed with @gregcaporaso out of loop.