Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Add capacity for axis position #198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JulianKingman
Copy link

Thank you for contributing a pull request.

Please ensure that you have signed the CLA.

  • I have signed the CLA

Closes #189

@marzolfb
Copy link
Contributor

My apologies for taking so long to respond to this PR. I took this PR for a test drive and added the position option to the axis options for the "StockLine - Basic" chart on the example app (just like you added to the docs) and I came up with something like this:

image

Did you intend for the text labels to go "inside" of the axis lines (i.e. to the bottom of the axis line at the top and to the left the axis line at the right)?

@JulianKingman
Copy link
Author

@marzolfb the orient property for the labels addresses that, doesn't it?

@marzolfb
Copy link
Contributor

You're right - I should've started with that screenshot instead. If you change the same example above to orient to 'top' on the x-axis and 'right' on the y-axis, you get this odd output:

image

I assume you must be working with a dataset+options in your testing that doesn't show the same odd behavior?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants