Raise error if automatically derived foreign keys are already present

cap-js · Jan 17, 2024 · 4bd7e60 · 4bd7e60
1 parent b2c0ca6
commit 4bd7e60
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/visitor.js b/lib/visitor.js
@@ -189,8 +189,13 @@ class Visitor {
                 // the containing entity.
                 for (const [kname, kelement] of this.#keys(element.target)) {
                     if (this.resolver.getMaxCardinality(element) === 1) {
-                        kelement.isRefNotNull = !!element.notNull || !!element.key
-                        this.visitElement(`${ename}_${kname}`, kelement, file, buffer)
+                        const foreignKey = `${ename}_${kname}`
+                        if (Object.hasOwn(entity.elements, foreignKey)) {
+                            this.logger.error(`Attempting to generate a foreign key reference called '${foreignKey}' in type definition for entity ${name}. But a property of that name is already defined explicitly. Consider renaming that property.`)
+                        } else {
+                            kelement.isRefNotNull = !!element.notNull || !!element.key
+                            this.visitElement(foreignKey, kelement, file, buffer)
+                        }
                     }
                 }
             }