Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rebrand /pricing/devices #14370

Open
wants to merge 1 commit into
base: pricing-rebrand
Choose a base branch
from
Open

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Oct 1, 2024

Done

QA

  • Open the demo
  • Check that it matches the figma design
  • Check it on all screen sizes
  • Check it follows accessibility guidelines

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12866

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@petesfrench
Copy link
Contributor Author

@mtruj013 Thank you for picking this up!

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petesfrench, just a few small suggestions

templates/pricing/devices.html Show resolved Hide resolved
templates/pricing/devices.html Show resolved Hide resolved
templates/pricing/devices.html Show resolved Hide resolved
templates/pricing/devices.html Show resolved Hide resolved
templates/pricing/devices.html Show resolved Hide resolved
templates/pricing/devices.html Show resolved Hide resolved
<h2 class="p-text--small-caps">Any questions?</h2>
</div>
<p class="p-heading--2">
Call us +1 737 204 0291 (Americas), +44 203 656 5291 (RoW) or <a href="https://ubuntu.com/pricing/devices#get-in-touch">Contact us online</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something for @Sophie-32 probably, but I don't think these phone numbers are used anymore. I remember we had to scrub mentions of them on u and c.com because according to marketing no one was picking up the phone 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! I remember that. Side note, do you also remember the number that was just some guys personal number (he at least worked for Canonical). I will wait for @Sophie-32 to respond on this one before merging, as this also appears on another couple pages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember that, but I wish I did 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants