refactor: Use built-in providers for installer model #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
reviewed
Apr 26, 2024
Comment on lines
+81
to
+84
| final mockInstallerService = MockInstallerService(); | ||
| when(mockInstallerService.monitorStatus()).thenAnswer( | ||
| (_) => Stream.value(fakeApplicationStatus(ApplicationState.RUNNING)), | ||
| ); |
There was a problem hiding this comment.
Would it maybe be better to override the new applicationStatusProvider in buildConfirmPage, instead of adding a mock response to the service?
There was a problem hiding this comment.
Yeah, it's either or I guess. Like this the code goes through the real provider too so one could argue that it gives slightly more code coverage, in this case I don't think it matters, so possibly we should override the provider since that is what we're doing in many other places.
There was a problem hiding this comment.
Ah I see, good point. Let's talk about it sometime next week and agree on a consistent approach so that testing in this code base becomes less of a nightmare :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #717